Fixes for 1.0.0 #90
Merged
Fixes for 1.0.0 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rmeissner
commented
Feb 22, 2019
rmeissner
commented
- Implemented critical proposals from https://github.com/runtimeverification/verified-smart-contracts/blob/master/gnosis/GnosisSafe_RuntimeVerification.pdf
- Adjusted EIP-1271 interface
- Cleanup of naming
rmeissner
commented
Feb 22, 2019
| //); | ||
| bytes32 public constant SAFE_TX_TYPEHASH = 0x14d461bc7412367e924637b363c7bf29b8f47e2f84869f4426e5633d8af47b20; | ||
| bytes32 public constant SAFE_TX_TYPEHASH = 0xbb8310d486368db6bd6f849402fdd73ad53d316b5a4b2644ad6efe0f941286d8; |
There was a problem hiding this comment.
@Uxio0 this will require changes in the clients, so we need to add a way that the clients know which version to use for signing (maybe return the contract version with the estimates)
There was a problem hiding this comment.
Alternatively we could stick to dataGas (but imo this is a really bad name ... on the other side the user will not see it)
There was a problem hiding this comment.
I would prefer that clients query the GET /safes/{address}/ endpoint, I don't like how the estimate endpoint is growing. Currently masterCopy, nonce, threshold and owners are returned, I will add version to that endpoint too. Would be ok for you @rmeissner?
rmeissner
commented
Feb 22, 2019
denisgranha
approved these changes
Feb 25, 2019
fdarian
pushed a commit
to fdarian/safe-contracts
that referenced
this pull request
Jan 14, 2024
* Fix SafeTransactionDataPartial import * fix documentation: wrong import (safe-global#87) * fix import Co-authored-by: Germán Martínez <germartinez@users.noreply.github.com> Co-authored-by: Parv Garg <parv3213@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.