Update CHANGELOG to Note Removal of encodeTransactionData
#855
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA. |
|
recheck |
mmv08
reviewed
Nov 4, 2024
mmv08
approved these changes
Nov 4, 2024
|
I think the CI fails since it runs on a fork-based branch for which I can't access the Certora key of course (would require |
mmv08
requested review from
a team,
nlordell,
akshay-ap and
remedcu
and removed request for
a team
Yes, the PR is good to go. I'm just waiting for a second opinion from my colleagues |
remedcu
reviewed
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🕓 Changelog
This PR adds a note in the
CHANGELOGindicating that theprivatefunctionencodeTransactionDatahas been completely removed and replaced with an optimised inline-assembly version via PR #847.