Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CORS error for UI #121

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix CORS error for UI #121

merged 1 commit into from
Nov 8, 2023

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Nov 7, 2023 •
edited
Loading

  • Run UI and services in the same host and port
  • Configure nginx as a proxy of the UI

@Uxio0 Uxio0 marked this pull request as ready for review November 8, 2023 11:47
@Uxio0 Uxio0 requested a review from a team as a code owner November 8, 2023 11:47
@Uxio0 Uxio0 requested review from fmrsabino, moisses89 and iamacook and removed request for a team November 8, 2023 11:47
moisses89
moisses89 approved these changes Nov 8, 2023
View reviewed changes
container_env_files/cgw.env Outdated
@@ -30,3 +30,10 @@ AUTH_TOKEN=your_privileged_endpoints_token
# Log level
LOG_LEVEL=info
# LOG_SILENT=true
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, fixed

@Uxio0
Fix CORS errors for UI
d8ddb3c 
- Run UI and services in the same host and port
- Configure nginx as a proxy of the UI
@Uxio0 Uxio0 merged commit 5cc20f3 into main Nov 8, 2023
2 checks passed
@Uxio0 Uxio0 deleted the fix-ui-cors branch November 8, 2023 13:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino is a code owner automatically assigned from safe-global/safe-services

@iamacook iamacook Awaiting requested review from iamacook iamacook is a code owner automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uxio0 @moisses89