Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for function handlers #47

Closed
rmeissner opened this issue Jul 21, 2023 · 1 comment · Fixed by #70
Closed

Add support for function handlers #47

rmeissner opened this issue Jul 21, 2023 · 1 comment · Fixed by #70
Assignees
@akshay-ap
Labels
enhancement New feature or request
Milestone
v0.2.0

Comments

@rmeissner
Copy link
Member

It should be possible to register the manager as a fallback handler and register function handlers.

In an initial version function handlers should be registered for a specific function selector.
@rmeissner rmeissner added this to the v0.2.0 milestone Jul 21, 2023
@akshay-ap akshay-ap added the enhancement New feature or request label Jul 24, 2023
@akshay-ap akshay-ap self-assigned this Jul 24, 2023
akshay-ap added a commit that referenced this issue Jul 27, 2023
@akshay-ap
[#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolMa…
175d0b9 
…nager
@akshay-ap akshay-ap mentioned this issue Jul 27, 2023
Merged
5 tasks
akshay-ap added a commit that referenced this issue Jul 27, 2023
@akshay-ap
[#47] Create BaseManager contract, rename modifier, rename error, che…
ef92c98 
…ck registry while adding function handler
akshay-ap added a commit that referenced this issue Jul 27, 2023
@akshay-ap
[#47] Update natspec doc
5a52eef
akshay-ap added a commit that referenced this issue Aug 6, 2023
@akshay-ap
[#47] Implement logic for non-static calls to function handler manage…
69e227c 
…r, test to set function handler
akshay-ap added a commit that referenced this issue Aug 7, 2023
@akshay-ap
[#47] Add tests for Function Handler
8bf6053
akshay-ap added a commit that referenced this issue Aug 7, 2023
@akshay-ap
[#47] Pass sender address in handle function
4a05518
akshay-ap added a commit that referenced this issue Aug 9, 2023
@akshay-ap
[#47] Fix tests
7f8981d
akshay-ap added a commit that referenced this issue Aug 9, 2023
@akshay-ap
[#47] Fix test
77d0b54
akshay-ap added a commit that referenced this issue Aug 9, 2023
@akshay-ap
[#47] Use ZeroAddress from ethers
b406518
akshay-ap added a commit that referenced this issue Aug 9, 2023
@akshay-ap
[#47] Test static call to function handler
675fe12
akshay-ap added a commit that referenced this issue Aug 9, 2023
@akshay-ap
[#47] Fix lint issue
0af2503
akshay-ap added a commit that referenced this issue Aug 9, 2023
@akshay-ap
[#47] Fix typo
842c2ad
akshay-ap added a commit that referenced this issue Aug 15, 2023
@akshay-ap
[#47] Update tests for Function Handler
cc7513c
akshay-ap added a commit that referenced this issue Aug 15, 2023
@akshay-ap
[#47] Update tests for function handler
1d749ec
akshay-ap added a commit that referenced this issue Aug 15, 2023
@akshay-ap
[#47] Remove test function handler from .solcover.js
68705f1
akshay-ap added a commit that referenced this issue Aug 15, 2023
@akshay-ap
[#47] Return data from handle function
eecbd26
akshay-ap added a commit that referenced this issue Aug 15, 2023
@akshay-ap
[#47] Verify call data passed to handle(...)
4029549
github-merge-queue bot pushed a commit that referenced this issue Aug 15, 2023
@akshay-ap @mmv08
Implement Guard interface in SafeProtocolManager (#51)
e68bd14 
* [#46] Implement Guard interface in SafeProtocolManager

* [#46] Setup Safe

* [#46] Fix EOF

* [#46] User setupTest function

* [#46] Fix lint issue

* [#46] Add tests

* [#46] Add test with delegateCall for hooks flow

* [#46] User temporary variable for storing hooks address

* [#47] Use ZeroAddress from ethers

* [#46] Reset tempHooksAddress

* [#46] Refactor tests for SafeProtocolManager as Guard

* [#46] Fix failing test

* [#46] Update comment

* Update test/SafeProtocolManager.spec.ts

Co-authored-by: Mikhail <mveehkim@gmail.com>

* [#46] Use setupTests() function

---------

Co-authored-by: Mikhail <mveehkim@gmail.com>
akshay-ap added a commit that referenced this issue Aug 16, 2023
@akshay-ap
[#47] Update doc string
707d39e
akshay-ap added a commit that referenced this issue Aug 16, 2023
@akshay-ap
[#47] Update RegistryManager
58f4b29
akshay-ap added a commit that referenced this issue Aug 16, 2023
@akshay-ap
[#47] Check if function handler is whitelisted
c262612
akshay-ap added a commit that referenced this issue Aug 16, 2023
@akshay-ap
[#47] Make fallback function non-payable, optimize codesize
28d5645
akshay-ap added a commit that referenced this issue Aug 16, 2023
@akshay-ap
[#47] Fix lint issue
9400aef
akshay-ap added a commit that referenced this issue Aug 17, 2023
@akshay-ap
[#47] Add ERC165 check while adding function handler
11ce14f
@akshay-ap akshay-ap mentioned this issue Aug 17, 2023
Merged
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Allow only self calls to manager
f48c12d
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Add tests for function handler
8319bfd
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Add tests
5d6abf4
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Rename function to checkCallerisSender()
754da7d
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Rename to OnlyAccountCallable, add docstrings
e2d5eec
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Update string in describe
1561278
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Update natspec doc for RegistryManager constructor
b8dec68
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Update natspec doc for RegistryManager constructor
7acc9cc
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#47] Update natspec doc for FunctionHandlerManager
e3c71ef
@akshay-ap akshay-ap mentioned this issue Aug 21, 2023
Closed
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2023
@akshay-ap
Support function handlers (#70)
ea7f2c3 
* [#46] Implement Guard interface in SafeProtocolManager

* [#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolManager

* [#47] Create BaseManager contract, rename modifier, rename error, check registry while adding function handler

* [#47] Update natspec doc

* [#46] Setup Safe

* [#46] Fix EOF

* [#46] User setupTest function

* [#46] Fix lint issue

* [#46] Add tests

* [#46] Add test with delegateCall for hooks flow

* [#46] User temporary variable for storing hooks address

* [#47] Implement logic for non-static calls to function handler manager, test to set function handler

* [#47] Add tests for Function Handler

* [#47] Pass sender address in handle function

* [#47] Fix test

* [#47] Use ZeroAddress from ethers

* [#46] Reset tempHooksAddress

* [#47] Test static call to function handler

* [#47] Fix lint issue

* [#47] Fix typo

* [#46] Refactor tests for SafeProtocolManager as Guard

* [#46] Fix failing test

* [#46] Update comment

* [#47] Update tests for Function Handler

* [#47] Update tests for function handler

* [#47] Remove test function handler from .solcover.js

* [#47] Return data from handle function

* [#47] Verify call data passed to handle(...)

* [#47] Update doc string

* [#47] Check if function handler is whitelisted

* [#47] Make fallback function non-payable, optimize codesize

* [#47] Fix lint issue

* [#47] Add ERC165 check while adding function handler

* [#47] Allow only self calls to manager

* [#47] Add tests for function handler

* [#47] Add tests

* [#47] Rename function to `checkCallerisSender()`

* [#47] Rename to OnlyAccountCallable, add docstrings

* [#47] Update string in describe

* [#47] Update natspec doc for RegistryManager constructor

* [#47] Update natspec doc for FunctionHandlerManager
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2023
@akshay-ap
Registry checks for hooks (#67)
c8c494d 
* [#46] Implement Guard interface in SafeProtocolManager

* [#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolManager

* [#47] Create BaseManager contract, rename modifier, rename error, check registry while adding function handler

* [#47] Update natspec doc

* [#46] Setup Safe

* [#46] Fix EOF

* [#46] User setupTest function

* [#46] Fix lint issue

* [#46] Add tests

* [#46] Add test with delegateCall for hooks flow

* [#46] User temporary variable for storing hooks address

* [#47] Implement logic for non-static calls to function handler manager, test to set function handler

* [#47] Add tests for Function Handler

* [#47] Pass sender address in handle function

* [#47] Fix test

* [#47] Use ZeroAddress from ethers

* [#46] Reset tempHooksAddress

* [#47] Test static call to function handler

* [#47] Fix lint issue

* [#47] Fix typo

* [#46] Refactor tests for SafeProtocolManager as Guard

* [#46] Fix failing test

* [#46] Update comment

* [#47] Update tests for Function Handler

* [#47] Update tests for function handler

* [#47] Remove test function handler from .solcover.js

* [#47] Return data from handle function

* [#47] Verify call data passed to handle(...)

* [#47] Update doc string

* [#47] Check if function handler is whitelisted

* [#47] Make fallback function non-payable, optimize codesize

* [#47] Fix lint issue

* [#53] Registry checks for hooks

* [#53] Remove chained assignments

* [#53] Fix failing tests

* [#53] Remove chained assignments

* [#53] Update comment on using temp hooks address

* [#53] Update data sent as parameter to pre-check hook in checkModuleTransaction, update natspec
github-merge-queue bot pushed a commit that referenced this issue Aug 23, 2023
@akshay-ap
Check if plugin supports expected interface Id when enabling (#74)
1fdfc1b 
* [#46] Implement Guard interface in SafeProtocolManager

* [#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolManager

* [#47] Create BaseManager contract, rename modifier, rename error, check registry while adding function handler

* [#47] Update natspec doc

* [#46] Setup Safe

* [#46] Fix EOF

* [#46] User setupTest function

* [#46] Fix lint issue

* [#46] Add tests

* [#46] Add test with delegateCall for hooks flow

* [#46] User temporary variable for storing hooks address

* [#47] Implement logic for non-static calls to function handler manager, test to set function handler

* [#47] Add tests for Function Handler

* [#47] Pass sender address in handle function

* [#47] Fix test

* [#47] Use ZeroAddress from ethers

* [#46] Reset tempHooksAddress

* [#47] Test static call to function handler

* [#47] Fix lint issue

* [#47] Fix typo

* [#46] Refactor tests for SafeProtocolManager as Guard

* [#46] Fix failing test

* [#46] Update comment

* [#47] Update tests for Function Handler

* [#47] Update tests for function handler

* [#47] Remove test function handler from .solcover.js

* [#47] Return data from handle function

* [#47] Verify call data passed to handle(...)

* [#47] Update doc string

* [#47] Check if function handler is whitelisted

* [#47] Make fallback function non-payable, optimize codesize

* [#47] Fix lint issue

* [#47] Add ERC165 check while adding function handler

* [#47] Allow only self calls to manager

* [#47] Add tests for function handler

* [#47] Add tests

* [#47] Rename function to `checkCallerisSender()`

* [#47] Rename to OnlyAccountCallable, add docstrings

* [#47] Update string in describe

* [#47] Update natspec doc for RegistryManager constructor

* [#47] Update natspec doc for FunctionHandlerManager

* [#73] Check if plugin supports expected interface Id when enabling

* [#73] Fix lint issue

* [#73] Add test for Manager: block EOA as Plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay-ap akshay-ap

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Support function handlers 5afe/safe-core-protocol
3 participants
@rmeissner @akshay-ap and others