Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry check while setting hook and function handlers #53

Closed
2 tasks done
akshay-ap opened this issue Jul 27, 2023 · 1 comment · Fixed by #67
Closed
2 tasks done

Add registry check while setting hook and function handlers #53

akshay-ap opened this issue Jul 27, 2023 · 1 comment · Fixed by #67
Assignees
@akshay-ap
Labels
enhancement New feature or request
Milestone
v0.2.0

Comments

@akshay-ap
Copy link
Contributor

akshay-ap commented Jul 27, 2023 •
edited
Loading

@akshay-ap akshay-ap added the enhancement New feature or request label Jul 27, 2023
@akshay-ap akshay-ap added this to the v0.2.0 milestone Jul 27, 2023
@akshay-ap akshay-ap self-assigned this Jul 27, 2023
@rmeissner rmeissner changed the title Add registry check while setting hook Add registry check while setting hook and function handlers Aug 14, 2023
@akshay-ap
Copy link
Contributor Author

Checks for function handler: c262612

akshay-ap added a commit that referenced this issue Aug 16, 2023
@akshay-ap
[#53] Registry checks for hooks
402e7a0
@akshay-ap akshay-ap mentioned this issue Aug 16, 2023
Merged
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#53] Remove chained assignments
dc0209a
akshay-ap added a commit that referenced this issue Aug 22, 2023
@akshay-ap
[#53] Fix failing tests
ac21ff5
akshay-ap added a commit that referenced this issue Aug 22, 2023
@akshay-ap
[#53] Remove chained assignments
88999a4
akshay-ap added a commit that referenced this issue Aug 22, 2023
@akshay-ap
[#53] Update comment on using temp hooks address
d448cb3
akshay-ap added a commit that referenced this issue Aug 22, 2023
@akshay-ap
[#53] Update data sent as parameter to pre-check hook in checkModuleT…
c5dbe31 
…ransaction, update natspec
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2023
@akshay-ap
Registry checks for hooks (#67)
c8c494d 
* [#46] Implement Guard interface in SafeProtocolManager

* [#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolManager

* [#47] Create BaseManager contract, rename modifier, rename error, check registry while adding function handler

* [#47] Update natspec doc

* [#46] Setup Safe

* [#46] Fix EOF

* [#46] User setupTest function

* [#46] Fix lint issue

* [#46] Add tests

* [#46] Add test with delegateCall for hooks flow

* [#46] User temporary variable for storing hooks address

* [#47] Implement logic for non-static calls to function handler manager, test to set function handler

* [#47] Add tests for Function Handler

* [#47] Pass sender address in handle function

* [#47] Fix test

* [#47] Use ZeroAddress from ethers

* [#46] Reset tempHooksAddress

* [#47] Test static call to function handler

* [#47] Fix lint issue

* [#47] Fix typo

* [#46] Refactor tests for SafeProtocolManager as Guard

* [#46] Fix failing test

* [#46] Update comment

* [#47] Update tests for Function Handler

* [#47] Update tests for function handler

* [#47] Remove test function handler from .solcover.js

* [#47] Return data from handle function

* [#47] Verify call data passed to handle(...)

* [#47] Update doc string

* [#47] Check if function handler is whitelisted

* [#47] Make fallback function non-payable, optimize codesize

* [#47] Fix lint issue

* [#53] Registry checks for hooks

* [#53] Remove chained assignments

* [#53] Fix failing tests

* [#53] Remove chained assignments

* [#53] Update comment on using temp hooks address

* [#53] Update data sent as parameter to pre-check hook in checkModuleTransaction, update natspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay-ap akshay-ap

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Registry checks for hooks 5afe/safe-core-protocol
1 participant
@akshay-ap