Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up installation #290

Merged
merged 13 commits into from
Aug 29, 2024
Merged

Clean up installation #290

merged 13 commits into from
Aug 29, 2024

Conversation

csangara
Copy link
Member

@csangara csangara commented Aug 1, 2024 •
edited
Loading

  • Remove limma dependency
    • Added conditional in classification_evaluation_continuous_pred() to only calculate GST if limma is installed
    • Added checks in evaluate_model() and evaluate_model_cv() to check for "mean_rank_GST_log_pval" in column names
    • Added note in evaluate_target_prediction() and the model_evaluation.Rmd vignette about this
  • Add biocViews to DESCRIPTION so ComplexHeatmap is automatically installed

@csangara csangara requested a review from browaeysrobin August 28, 2024 12:46
@csangara
Copy link
Member Author

Checks passed for all recent release, it only failed for the previous release due to rjson dependency from ComplexHeatmap.

@csangara csangara merged commit 842946d into master Aug 29, 2024
4 of 5 checks passed
@csangara csangara deleted the install branch August 29, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@browaeysrobin browaeysrobin Awaiting requested review from browaeysrobin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@csangara