Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Implicitly marking parameter $param as nullable is deprecated #673

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix Implicitly marking parameter $param as nullable is deprecated #673

merged 1 commit into from
Oct 14, 2024

Conversation

cedric-anne
Copy link
Contributor

This fixes deprecation warnings triggered in PHP 8.4.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (ccbf597) to head (0795cd7).
Report is 5 commits behind head on 4.5.

Additional details and impacted files
@@            Coverage Diff            @@
##                4.5     #673   +/-   ##
=========================================
  Coverage     98.65%   98.65%           
- Complexity     1907     1930   +23     
=========================================
  Files            71       71           
  Lines          5294     5294           
=========================================
  Hits           5223     5223           
  Misses           71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis merged commit fda12d4 into sabre-io:4.5 Oct 14, 2024
10 checks passed
@phil-davis
Copy link
Contributor

Note: these changes happened in master PR #637 commit 5c3a532

I double-checked by trying to forward-port these changes, and they all result in merge-conflicts of code that is already fixed in master.

@cedric-anne cedric-anne deleted the feature/php-8.4 branch October 14, 2024 07:25
@phil-davis
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants