-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculating VAVAILABILITY #242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shockingly no syntax errors on the first try.
Not gonna bother with making it faster. It's much better this way and we already got major speedups in the 4.x branch, I think it's within acceptable limits. I'm also not reintegrating FreeBusyData into FreeBusyGenerator. It's a bit unfortunate to have a separate class, but it does make things a lot more clear. So when I fixed the broken tests, this is ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress to add VAVAILABILITY calculations to sabre/vobject.
VAVAILABILITY is currently largely useful in when generating freebusy reports, so this is also where this needs to be fixed. It makes the calculations a lot more complex, so it's also requiring some refactoring in the freebusy generator.
Todo:
Benchmark
Old:
New:
Unfortunately it seems that the new system is quite a bit slower. We'll have to figure out how important it is to fix this, and if there's some easy wins to be made.