Dealing with EXDATES in ITip\Broker & fix for #126 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably related to sabre-io#126
| @@ -855,7 +855,10 @@ protected function parseEventInfo(VCalendar $calendar = null) { | |||
| $sequence = $vevent->SEQUENCE->getValue(); | |||
| } | |||
| if (isset($vevent->EXDATE)) { | |||
| $exdate = $vevent->EXDATE->getParts(); | |||
| foreach ($vevent->select('EXDATE') as $val) { | |||
| $exdate = array_merge($exdate, $val->getParts()); | |||
There was a problem hiding this comment.
Should we consider the PRIORITY property here to sort EXDATE before merging them? Because order is important when merging.
There was a problem hiding this comment.
As discussed via Slack yesterday you: there is no relation between PRIORITY and EXDATE. And the exdates get sorted (so we have earliest to latest in our variable) after merging values of all EXDATE-properties.
Did I miss something?
|
anything missing for you, @evert? :) |
evert
added a commit
that referenced
this pull request
Feb 18, 2015
…ificantChange-check Dealing with EXDATES in ITip\Broker & fix for #126
|
Sorry for the delay armin. Just noticed this on my todo list from a few days ago :S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two issues:
EXDATEpresent in an objectEXDATE-values in a PUT, the$significantChangeHashwould imply a real change of the event happenedAlso see the initial issue & the thread in this commit.