Keep floating time on Recur\EventIterator::getEventObject #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y expand with reference timezone (if any)
|
👍 |
|
Nice! |
evert
added a commit
that referenced
this pull request
Jan 21, 2015
Keep floating time on Recur\EventIterator::getEventObject
|
|
||
| /** | ||
| * This is a unittest for Issue #53. | ||
| */ |
There was a problem hiding this comment.
No :-) 53 is about something else, I think.
There was a problem hiding this comment.
Argh, my bad! Didn't recheck after duplicating the file from another test. :/
|
The Gang of Bad Reviewers™ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to correctly expand with reference timezone (if any).
This fixes a problem where recurrent events with floating times would get set to UTC by EventIterator::getEventObject() while it should be transferred to UTC in VCalendar::expand().