test for vcard converter issue #173
Conversation
|
Please add this test to VCardConverterTest. IssueXXTest is a bad convention |
|
Updated. |
| $vcard = Reader::read($input); | ||
|
|
||
| $this->assertInstanceOf('Sabre\\VObject\\Component\\VCard', $vcard); | ||
| $vcard = $vcard->convert(\Sabre\VObject\Document::VCARD40); |
There was a problem hiding this comment.
Simply using VObject\Document::VCARD40 might be valid here (because of the namespace).
There was a problem hiding this comment.
Not sure what is preferred here. It's not omitted anywhere in the test class.
Should probably be omitted everywhere or nowhere. :)
There was a problem hiding this comment.
Sorry, didn't check around this test case. Yes, it should be omitted everywhere ;-).
|
Build fails inside the converter class. |
|
Yup. |
|
Checking if
Don't think that would be the expected conversion. |
|
What is the expected value? |
|
The vCard 3.0 version had no (Anniversary) label property, so I wasn't sure about the vCard 4.0 representation as |
vCard converter fails for X-ABDATE properties that have no X-ABLABEL.
Thanks, @armin-hackmann! :-)