The $uri and $method params are now required when setting up Request. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that it's not possible to create a Request object that's not valid.
staabm
reviewed
Oct 13, 2016
| @@ -117,6 +120,13 @@ function setAbsoluteUrl(string $url) { | |||
| */ | |||
| function getAbsoluteUrl() : string { | |||
|
|
|||
| if (!$this->absoluteUrl) { | |||
| // Guessing we're a http endpoint. | |||
| $this->absoluteUrl = 'http://' . | |||
There was a problem hiding this comment.
Shouldnt we guess the protocoll based on e.g. The request uri, port or something?
Or maybe define the default protocol somewhere?
There was a problem hiding this comment.
So we kind of do both already. Usually the absolute url comes from the Sapi. It actually populates absoluteUrl using the information from $_SERVER and tends to do this accurately.
In cases where you are using the object in a client, you generally populate the information yourself. A request without an absolute url cannot be made really. This is really the ultimate fallback if all else fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that it's not possible to create a Request object that's
not valid.