Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getCredentials returns null if incomplete #43

Merged
merged 2 commits into from
Mar 30, 2015
Merged

getCredentials returns null if incomplete #43

merged 2 commits into from
Mar 30, 2015

Commits on Mar 19, 2015

  1. getCredentials returns null if incomplete. 

    If the colon is missing (in `user:password`), `getCredentials` will
return an array of one value instead of null whereas this is incorrect.
We then check that the credentials form a pair of two values.
    @Hywan
    Hywan committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    c0a71ac View commit details
    Browse the repository at this point in the history

  2. Test the previous commit.

    @Hywan
    Hywan committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    4b149f0 View commit details
    Browse the repository at this point in the history