Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PHP 8.4 to CI of 5.1 branch #241

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 26, 2024

and adjust code for PHP 8.4 compliance.

Related issue sabre-io/event#123

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (2941a44) to head (1af5fd5).
Report is 1 commits behind head on 5.1.

Additional details and impacted files
@@            Coverage Diff            @@
##                5.1     #241   +/-   ##
=========================================
  Coverage     94.14%   94.14%           
- Complexity      263      266    +3     
=========================================
  Files            15       15           
  Lines           871      871           
=========================================
  Hits            820      820           
  Misses           51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis merged commit da737de into sabre-io:5.1 Jul 26, 2024
11 checks passed
@phil-davis phil-davis deleted the ci-php-84 branch July 26, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant