Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle client disconnect properly with ignore_user_abort true #207

Merged
merged 2 commits into from
Jun 26, 2023
Merged

fix: handle client disconnect properly with ignore_user_abort true #207

merged 2 commits into from
Jun 26, 2023

Commits on Jun 26, 2023

  1. fix: handle client disconnect properly with ignore_user_abort true 

    ignore_user_abort(true) instruct php to not abort the script on client disconnect.
To avoid reading the entire stream and dismissing the data afterward, check between the chunks if the client is still there.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
    @kesselb @phil-davis
    kesselb authored and phil-davis committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f2a1635 View commit details
    Browse the repository at this point in the history

  2. Declare return type of stream_read in test

    @phil-davis
    phil-davis committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c574923 View commit details
    Browse the repository at this point in the history