break stream if connection got aborted

[szaimen]

Fix nextcloud/server#19567

See nextcloud/server#19567 (comment)

[staabm]

thanks for the patch. could you come up with a test case reproducing the initial problem ?

[codecov]

Codecov Report

Merging #205 (d3ee521) into master (16c1509) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #205   +/-   ##
=========================================
  Coverage     94.50%   94.50%           
- Complexity      256      257    +1     
=========================================
  Files            15       15           
  Lines           873      873           
=========================================
  Hits            825      825           
  Misses           48       48           

Impacted Files	Coverage Δ
lib/Sapi.php	99.04% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[yevon]

Any news about this one? Really interested in getting this fixed as this causes lots of issues on nextcloud.

[staabm]

could you come up with a test case reproducing the initial problem ?

[yevon]

I'm just a nextcloud user that does use this lib indirectly. But in order to properly test this it should:

1 - Download a very big file multiple times simultaneously.
2 - Interrupt connections unexpectedly, like a web browser close etc.
3 - Check that process count, or disk usage is 0 soon after connection interruption. Now it continues reading the file until it is read completely causing the server to die if you continue downloading new files. It causes lots of problems on http range requests for video streamming. Not really sure if it is library specific or a wrong usage of this lib. But this makes nextcloud to hit enormous server usage on file downloads or video streamming.

[szaimen]

Superceded by #207