Add phpstan phpunit strict-rules

[phil-davis]

No description provided.

[codecov]

Codecov Report

Merging #203 (dbc86e4) into master (fcc83fa) will decrease coverage by 0.19%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##             master     #203      +/-   ##
============================================
- Coverage     94.40%   94.21%   -0.19%     
- Complexity      258      260       +2     
============================================
  Files            15       15              
  Lines           875      881       +6     
============================================
+ Hits            826      830       +4     
- Misses           49       51       +2     

Impacted Files	Coverage Δ
lib/Response.php	100.00% <ø> (ø)
lib/Client.php	84.16% <75.00%> (-0.32%)	⬇️
lib/Auth/Basic.php	93.75% <80.00%> (-6.25%)	⬇️
lib/Auth/AWS.php	89.61% <100.00%> (+0.13%)	⬆️
lib/Auth/Bearer.php	100.00% <100.00%> (ø)
lib/Auth/Digest.php	96.42% <100.00%> (ø)
lib/Request.php	100.00% <100.00%> (ø)
lib/Sapi.php	98.13% <100.00%> (ø)
lib/functions.php	97.90% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[phil-davis]

Error: Call to function base64_decode() requires parameter #2 to be set.
Error: Call to function in_array() requires parameter #3 to be set.
Error: Call to function array_key_exists() with 'size' and array{0: int, 1: int, 2: int, 3: int, 4: int, 5: int, 6: int, 7: int, ...} will always evaluate to true.
 ------ ------------------------------------------------------------------- 
  Line   lib/Auth/Basic.php                                                 
 ------ ------------------------------------------------------------------- 
  42     Call to function base64_decode() requires parameter #2 to be set.  
 ------ ------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   lib/Client.php                                                         
 ------ ----------------------------------------------------------------------- 
  125    Call to function in_array() requires parameter #3 to be set.           
  390    Call to function array_key_exists() with 'size' and array{0: int, 1:   
         int, 2: int, 3: int, 4: int, 5: int, 6: int, 7: int, ...} will always evaluate to true.                                                      
 ------ ----------------------------------------------------------------------- 

Error:  [ERROR] Found 3 errors

Note: the new phpstan-strict-rules enforce that base64_decode and in_array are always called with the "strict" parameter set to true. I have adjusted the code to do that.

I have ignored the "will always evaluate to true" message. The check is a bit superfluous, but it does not hurt to keep it.

[staabm]

Could we instead declar wthe type of the propery?

[phil-davis]

phpstan-strict-rules wants all if checks to be real booleans.
We can only call $errorCallback if it is a callback anyway.

sendAsyncInternal already has this passed in as a callback.

[phil-davis]

Declaring the type as callable will not stop the strict rule complaining that the if condition is not a real boolean.

[phil-davis]

I added details of the "array shape" of curlMultiMap (see below in the diffs).

[phil-davis]

This at least helps to document what this array-of-arrays should look like.
But I locally tried specifying wrong things here, and I couldn't get phpstan to give any errors - I was expecting that lines of code that set and/or use entries in this array would cause phpstan to complain.

[phil-davis]

@staabm I pushed another commit:
dbc86e4

That moves the declaration of the "shape" of $curlMultiMap to the declaration of the property.

Does that seem OK/better to you?

[staabm]

looks good, thanks.