Test enhancement #176
Merged
Test enhancement #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
============================================
+ Coverage 94.11% 94.90% +0.78%
Complexity 260 260
============================================
Files 15 15
Lines 884 883 -1
============================================
+ Hits 832 838 +6
+ Misses 52 45 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phil-davis
commented
Nov 2, 2021
lib/functions.php
Outdated
| var_dump($mimeType); | ||
| exit(); | ||
| // throw new InvalidArgumentException('Not a valid mime-type: '.$str); | ||
| throw new InvalidArgumentException('Not a valid mime-type: '.$str); |
There was a problem hiding this comment.
@staabm @DeepDiver1975 this changes this function so that it can throw an exception. This is the only exception thrown in the whole of functions.php Other functons in this code return false if something goes wrong.
The existing code just exits!
Are callers going to be OK with this function now throwing an exception? Or?
Closed
phil-davis
force-pushed
the
test_enhancement-rebased-20211102
branch
from
9d7f508
to
3501890
Compare
phil-davis
force-pushed
the
test_enhancement-rebased-20211102
branch
from
d45baf3
to
78b519c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #98
I rebased again today 2022-08-26, removed the small "real" code change that was in
lib/functions.phpand squashed. Now this just has extra test cases, which looks fine. I will merge.