Code optimization #114
Merged
Code optimization #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=========================================
Coverage 88.21% 88.21%
+ Complexity 244 242 -2
=========================================
Files 15 15
Lines 789 789
=========================================
Hits 696 696
Misses 93 93
Continue to review full report at Codecov.
|
|
IMO we should drop the 2 commits we discussed. otherwise this looks good to me. thx for the PR. |
|
I've removed these two commits. Now everything should be OK. |
|
can I ask you to squash the commits a bit into reasonable units? THX |
Direct comparison is faster Type casting is faster
unnecessary type casting redundant else keyword resolving tests errors - type casting pretty fix pretty fix
evert
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code optimization using PHPStorm plugin.