-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance CardDAV query report to return a selective list of vcard prop… #903
Enhance CardDAV query report to return a selective list of vcard prop… #903
Conversation
is that related to my changes?
|
I somehow remember a PR which was merged lately to add the charset for the basic auth backend. I guess this is not related to your PR |
Found it: Not sure why it fails here, maybe a dependency version problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the issue with sabre/http. This was indeed an update in sabre/http that happened earlier and now caused sabre/dav to fail.
There is still a small CS problem though. Just run ./bin/sabre-cs-fixer fix lib/Sabre/CardDAV/Plugin.php
* @return string | ||
*/ | ||
protected function convertVCard($data, $target) { | ||
protected function convertVCard($data, $target, $propertiesFilter = null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this get can array
typehint?
ed21376
to
ea633dc
Compare
ea633dc
to
c1bb682
Compare
@evert done |
Awesome feature @DeepDiver1975 |
My pleasure. What's your view on backporting this? |
Totally up for a backport! Doesn't seem like this would cause any sort of BC breaks. Happy to all the way back to 3.0 (which is the lowest supported version). |
…erties - fixes #889
@evert