-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add propFindUnfiltered public method to Client (4.6) #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns all the properties received in the server response, even for resources that have a status that is not 200 (success).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.6 #1526 +/- ##
======================================
Coverage ? 97.32%
Complexity ? 2836
======================================
Files ? 175
Lines ? 9433
Branches ? 0
======================================
Hits ? 9181
Misses ? 252
Partials ? 0 ☔ View full report in Codecov by Sentry. |
phil-davis
commented
Dec 11, 2023
staabm
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1519
To preserve backward-compatibility I added the last commit db80aae in addition to all the commits from master.
The original client
propFind
function needs to preserve its existing untyped parameters to be strictly backward-compatible.I added some unit test cases to check what happens when
$url
is passed as anint
(a file called "123456" might be passed as the integer123456
), and what happens when depth of1
is passes as the string "1". We should let callers still be able to do those things in the current release series.