Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add params for put interface #1290

Closed
wants to merge 3 commits into from
Closed

add params for put interface #1290

wants to merge 3 commits into from

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Aug 11, 2020

for later usage like nextcloud/server#22019

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1290 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1290      +/-   ##
============================================
+ Coverage     97.12%   97.14%   +0.01%     
- Complexity     2774     2792      +18     
============================================
  Files           174      174              
  Lines          8028     8118      +90     
============================================
+ Hits           7797     7886      +89     
- Misses          231      232       +1     
Impacted Files Coverage Δ Complexity Δ
lib/CalDAV/CalendarObject.php 100.00% <100.00%> (ø) 19.00 <2.00> (ø)
lib/CalDAV/Schedule/SchedulingObject.php 95.45% <100.00%> (ø) 9.00 <1.00> (ø)
lib/CardDAV/Card.php 100.00% <100.00%> (ø) 18.00 <2.00> (ø)
lib/DAV/CorePlugin.php 95.30% <100.00%> (+0.10%) 113.00 <0.00> (ø)
lib/DAV/FS/File.php 100.00% <100.00%> (ø) 6.00 <1.00> (ø)
lib/DAV/FSExt/File.php 100.00% <100.00%> (ø) 11.00 <1.00> (ø)
lib/DAV/File.php 100.00% <100.00%> (ø) 5.00 <1.00> (ø)
lib/DAV/Server.php 96.13% <100.00%> (-0.18%) 192.00 <3.00> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7101bbe...1e9ee6d. Read the comment docs.

@phil-davis
Copy link
Contributor

@yrong I made a rebased PR #1365 and added PHPdoc etc there.

Is this enhancement still required?

@phil-davis phil-davis mentioned this pull request Nov 30, 2021
@phil-davis
Copy link
Contributor

Merged in #1365

@phil-davis phil-davis closed this Nov 30, 2021
@phil-davis
Copy link
Contributor

@yrong see discussion in #1365 (comment)

This change, as it is, is not strictly backward-compatible. I had released it today in 4.2.2. I had to revert it and release 4.2.3.

If you need this change/enhancement then please mention here the detail of where it will be used. Then we can think how best to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants