Rename create functions to match V2 core

[smol-ninja]

Closes #263

Requirements for passing ALL tests

• Rename create functions v2-core#798 to be merged first
• Update precompiles in v2-core
• Update v2-core version in package.json

  v2-periphery/package.json

  Line 15 in 0925e93

  "@sablier/v2-core": "1.1.2"

[andreivladbrg]

i think this PR is going to be on hold, since we release a new NPM version

@PaulRBerg should we have NPM releases more often which should be marked as "beta" e.g. 1.1.3-b?

[PaulRBerg]

Good point about the NPM version, @andreivladbrg.

should we have NPM releases more often which should be marked as "beta" e.g. 1.1.3-b?

Nope. We can simply install V2 Core from GitHub:

"@sablier/v2-core": "github:sablier-labs/v2-core#staging"

[andreivladbrg]

Nope. We can simply install V2 Core from GitHub:

correct, forgot that it now works because of the bun install CLI ran before, it used to not work due to pre-pack

[smol-ninja]

We can simply install V2 Core from GitHub

Yup. That's how I tested it locally but didn't push it as I wasn't sure how we maintain separate packages for staging and main.

[andreivladbrg]

@smol-ninja merged the core PR on staging and updated the precompiles, you can update this PR too

regarding the fork tests, you can temporarily deploy the core contracts and comment this line:

v2-periphery/test/fork/Fork.t.sol

Line 35 in d355029

loadDependencies();

[smol-ninja]

you can temporarily deploy the core contracts and comment this line:

@andreivladbrg Sorry but I didn't get what you meant by this. Do you mean deploying the staging branch on the mainnet? And how does commenting on that line help?

[andreivladbrg]

Sorry but I didn't get what you meant by this. Do you mean deploying the staging branch on the mainnet? And how does commenting on that line help?

ah, no no, poor wording on my side

we just need to do the same thing as in the Integration_Test contract:

v2-periphery/test/integration/Integration.t.sol

Lines 39 to 41 in d355029

	function deployDependencies() private {
	(comptroller, lockupDynamic, lockupLinear,) = new V2CorePrecompiles().deployCore(users.admin);
	}

[smol-ninja]

@andreivladbrg can you please have a last look at this and suggest or approve changes?

[andreivladbrg]

LGTM

just one small miss:

v2-periphery/test/Base.t.sol

Line 139 in c686264

function expectCallToCreateWithRangeLL(LockupLinear.CreateWithTimestamps memory params) internal {