Modifiers for each testing branch (plus other enhancements)

[PaulRBerg]

Changelog:

• Implement Modifiers for each testing branch #77 using the V4 method agreed upon in discussion #91
• Remove the UnitTest descriptor from each contract name (the contract names have become quite long)
• Rename the streamId variable to daiStreamId to make it clear that we're referring to a $DAI stream

[andreivladbrg]

We are going to use V4 #91 (comment).

[PaulRBerg]

In commits 50844c0 and a62326f, you have re-added the UnitTest descriptor in each testing contract name. Haven't you seen the changelog in my original comment? I have purposefully removed UnitTest.

[PaulRBerg]

In commit test: change test functions name, you have bumped solidity to v0.8.15, which is quite an important change. It should have been the first message, listed at the top.

[PaulRBerg]

I fixed a couple of mistakes in your implementation @andreivladbrg.

1. In sablier-v2-linear/cancel.t.sol, you forgot to add the StreamEnded descriptor in the test function for the case when the stream ended which tests that the Cancel event gets emitted (testCancel__Event should have been testCancel__StreamEnded__Event)
2. The branches in sablier-v2-linear/create.t.sol and sablier-v2-pro/create.t.sol have not been construed correctly. You should have mirrored the Token6Decimals and Token18Decimals descriptors, and likewise the CallerNotSender and CallerSender descriptors, instead of creating modifiers for them.
3. The branches in sablier-v2-pro/getWithdrawableAmount.t.sol have not been construed correctly. You should have mirrored the Token6Decimals and Token18Decimals descriptors, and likewise the OneSegment and MultipleSegments descriptors, instead of creating modifiers for them.
4. The function testCannotCreate in sablier-v2-pro/create.t.sol should have been named testCannotCreate__StartTimeGreaterThanFirstMilestone.
5. The function testWithdrawAll__CallerSender should have been named testWithdrawAll__CallerSenderAllStreams.
6. You forgot to create a modifier for the case when the caller is the sender in the sablier-v2-linear/withdraw.t.sol tests.

As a rule of thumb, whenever there are complex branches which do not revert early, the names of the test functions should follow the testing branches so that we don't end up with name collisions.

[PaulRBerg]

Gonna merge this now. Good job @andreivladbrg.

[andreivladbrg]

1. Right, missed that.
2. I think you missed that for the create function from the linear contract because you use descriptors and the modifier:
   https://github.com/sablierhq/v2-core/blob/1139d8b93b3f91a758590ed106e3d81a03c6a84c/test/unit/sablier-v2-linear/create/create.t.sol#L364-L373
3. Ok
4. I don't understand.
5. Ok.
6. Right, missed that.

[PaulRBerg]

I think you missed that for the create function from the linear contract because you use descriptors and the modifier:

Good catch. Fixed on main via eb36d41.

I don't understand.

See this: testCannotCreate. It should have been named testCannotCreate__StartTimeGreaterThanFirstMilestone.

[andreivladbrg]

See this: testCannotCreate. It should have been named testCannotCreate__StartTimeGreaterThanFirstMilestone.

Oh, didn't see that.