Update forge-std to v1.8.1 #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: remove @prb/test dep test: rename `timestamp` to `newTimestamp` in `vm.warp` test: declare some functions as `pure` and `view` test: rename `assumeNoPrecompiles` to `assumeNotPrecompile` test: use StdAssertions log events test: define BaseVm contract test: define MAX_UINT256 in Constants
smol-ninja
commented
Mar 23, 2024
PaulRBerg
requested changes
Mar 23, 2024
This was referenced Mar 24, 2024
|
@PaulRBerg, I have incorporated your suggestions. |
andreivladbrg
approved these changes
Mar 25, 2024
|
Yes @andreivladbrg. I've created a separate issue for that. |
I am sorry. I've missed that issue. |
|
In Should I delete BaseVm and inherit from |
IMO we should delete |
|
agree with @andreivladbrg |
smol-ninja
force-pushed
the
test/forge-std-v1.8.1
branch
from
311b3fa to
169947e
Compare
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* build: update forge-std to v1.8.1 build: remove @prb/test dep test: rename `timestamp` to `newTimestamp` in `vm.warp` test: declare some functions as `pure` and `view` test: rename `assumeNoPrecompiles` to `assumeNotPrecompile` test: use StdAssertions log events test: define BaseVm contract test: define MAX_UINT256 in Constants * test: Use from forge-std * test(refactor): rename log names in Assertions * build: update prb math peer dep version * chore: address pr feedback * chore: update bun.lockb file * test: use CommonBase for vm * test: deprecate changePrank in favor of resetPrank --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com> Co-authored-by: Paul Razvan Berg <paul.razvan.berg@gmail.com>
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* build: update forge-std to v1.8.1 build: remove @prb/test dep test: rename `timestamp` to `newTimestamp` in `vm.warp` test: declare some functions as `pure` and `view` test: rename `assumeNoPrecompiles` to `assumeNotPrecompile` test: use StdAssertions log events test: define BaseVm contract test: define MAX_UINT256 in Constants * test: Use from forge-std * test(refactor): rename log names in Assertions * build: update prb math peer dep version * chore: address pr feedback * chore: update bun.lockb file * test: use CommonBase for vm * test: deprecate changePrank in favor of resetPrank --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com> Co-authored-by: Paul Razvan Berg <paul.razvan.berg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #842, #843, #866 and #747 (1st task only).
Subtasks
changePrank#866Notable changes
@prb/testdepOther changes
timestamptonewTimestampinvm.warpassumeNoPrecompilestoassumeNotPrecompile