Implement ERC721 standard in both Linear and Pro contracts #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use modifier for the "cancel" function
feat: inherit ERC721 in SablierV2Pro feat: mint NFT in the create function feat: add isApprovedOrOwner function feat: change modifier to onlySenderOrRecipientOrApproved feat: add tokenURI function perf: remove the recipient address from the Stream struct test: change the struct recipient with the user recipient
test: make recipient the default caller for the cancel tests test: when the recipient is no longer the owner of the stream in the cancel function test: when the recipient is no longer the owner of the stream in the withdraw function test: when the recipient is no longer the owner of the streams in the cancellAll function test: when the caller is an approved third party in the cancel function test: when the caller is an approved third party in the cancelAll funtion test: when the caller is an approved third party in the withdraw function test: order correctly the branches in the cancel tree test: order correctly the branches in the cancelAll tree
test: when the recipient is no longer the owner of the streams in the withdrawAll function test: when the recipient is no longer the owner of the streams in the withdrawAllTo function test: when the recipient is no longer the owner of the stream in the withrawTo function test: when the caller is an approved third party in the withdrawAll function test: when the caller is an approved third party in the withdrawAllTo function test: when the caller is an approved third party in the withdtawTo function test: order correctly the branches in the withdraw tree test: remove the local withdrawAmount variable from the test functions test: change the new owner of the streams to eve when using transfer function
test: correct function name in the withdrawAllTo test: improve english in the tree branches
andreivladbrg
force-pushed
the
andrei/feat-erc721
branch
from
e9a6469 to
27ab5ab
Compare
test: "isApprovedOrOwner" function in the "SablierV2Pro" contract test: correct comment about return value
andreivladbrg
force-pushed
the
andrei/feat-erc721
branch
2 times, most recently
from
d131c0a to
8fdf71d
Compare
|
Due to too many git conflicts I'm closing this PR in favor of #131. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features implemented:
createfunction in both contractsrecipientaddress from theStreamstruct in both contractsisApprovedOrOwnerfunction that returns aboolvalue wether the caller is theownerof the stream or isapprovedonlySenderOrRecipientmodifier toonlySenderOrAuthorizedthat callsisApprovedOrOwnerfunctionapprovedthird party in thecancelcancelAllwithdrawwithdrawAllwithdrawAllTowithdrawTofunctionscancelcancelAllwithdrawwithdrawAllwithdrawAllTowithdrawTofunctions