Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow voiding solvent streams #290

Merged
merged 3 commits into from
Oct 7, 2024
Merged

feat: allow voiding solvent streams #290

merged 3 commits into from
Oct 7, 2024

Conversation

smol-ninja
Copy link
Member

Changelog

  • feat: allow voiding solvent streams
  • feat: allow refund from voided streams
  • test(fuzz): include solvent and insolvent streams on void tests
  • test(benchmark): include gas cost for voiding a solvent stream
  • docs(diagrams): update diagrams
  • docs(readme): update readme
  • docs(technical doc): update invariant
  • update auditor handbook

andreivladbrg
andreivladbrg requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, feedback below (will create a separate PR to address some of them):

src/SablierFlow.sol Outdated Show resolved Hide resolved
src/SablierFlow.sol Outdated Show resolved Hide resolved
src/SablierFlow.sol Outdated Show resolved Hide resolved
src/SablierFlow.sol Show resolved Hide resolved
tests/fork/Flow.t.sol Outdated Show resolved Hide resolved
tests/integration/concrete/refund/refund.tree Show resolved Hide resolved
andreivladbrg added a commit that referenced this pull request Oct 7, 2024
@andreivladbrg
address my feedback on #290
300f319
@andreivladbrg andreivladbrg mentioned this pull request Oct 7, 2024
Closed
@smol-ninja
Copy link
Member Author

The new diagram change looks good.

smol-ninja and others added 3 commits October 7, 2024 20:11
@smol-ninja @andreivladbrg
feat: allow void for solvent streams
e3b9529 
feat: allow refund on voided streams
docs: update docs
docs(benchmark): include gas cost for voiding a solvent streams
test: update concrete, fuzz and invariants
@andreivladbrg
docs: update diagrams
82bf967
@andreivladbrg
address feedback
230410e 
update precompiles
@andreivladbrg andreivladbrg merged commit 6b941ae into main Oct 7, 2024
7 checks passed
@andreivladbrg andreivladbrg deleted the refactor/void branch October 7, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreivladbrg andreivladbrg andreivladbrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smol-ninja @andreivladbrg