Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't update st if withdraw amount is less than sd #266

Merged
merged 4 commits into from
Sep 30, 2024
Merged

perf: don't update st if withdraw amount is less than sd #266

merged 4 commits into from
Sep 30, 2024

Conversation

andreivladbrg
Copy link
Member

No description provided.

smol-ninja
smol-ninja requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@smol-ninja smol-ninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withdraw concrete tests should be updated to cover both the branches.

├── when amount not exceed snapshot debt
│   └── goes here
└── when amount exceed snapshot debt
    └── goes here

tests/integration/concrete/withdraw-max/withdrawMax.t.sol Show resolved Hide resolved
@andreivladbrg
Copy link
Member Author

withdraw concrete tests should be updated to cover both the branches.

you are correct, added them in my latest commit

lmk if the PR looks good now

smol-ninja
smol-ninja approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreivladbrg andreivladbrg merged commit d25a946 into main Sep 30, 2024
7 of 8 checks passed
@andreivladbrg andreivladbrg deleted the perf/optimize-withdraw branch September 30, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smol-ninja smol-ninja smol-ninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreivladbrg @smol-ninja