Refactor project and contracts to SablierFlow #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
refactor/rename-flow
branch
from
ce16e76 to
7c94173
Compare
docs: update README.md docs: capitalize flow to Flow test: fix misspelled labelContracts in Bast.t.sol
smol-ninja
requested changes
May 24, 2024
There was a problem hiding this comment.
Two comments:
- We should always use Capitalized version in the docs when referring to "Flow" instead of "flow" because its a name.
- Since flow is also a verb, some of the docs stopped making sense which I have addressed in .
Adddressed in ceb9b0e.
test: rename deploy contract functions
haha 😂 @smol-ninja pushed a new commit, lmk if it looks good |
|
I have seen it. Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
SablierV2OpenEndedtoSablierFlow#95.Changelog
Note: after this PR is merged, we also need to update the repo name.