depositViaBroker and createAndDepositViaBroker functions
#100
Conversation
smol-ninja
force-pushed
the
feat/broker
branch
2 times, most recently
from
ff43ea3 to
8707297
Compare
test/integration/create-and-deposit-via-broker/createAndDepositViaBroker.tree
Outdated
Show resolved
Hide resolved
test: depositViaBroker test: createAnddepositViaBroker refactor: address pr review test: move broker function from Base to Integration test: remove duplicated modifiers test: remove unneeded tree branches test: fix CreateAndDepositViaBroker_Integration_Test
test: rename whenRecipientNonZeroAddress to whenRecipientIsNotZeroAddress
|
@andreivladbrg I have addressed the merge conflicts. In doing so, I am sorry that I overwrote your commits because I first squashed them followed by cherry-pick. Next time, will find a way of squashing without changing the co-author. There is one question that I asked in the PR description: Question: Modifiers in Otherwise if everything looks good, please lmk. |
test: order modifiers alphabetically test: add delegate call test for withdrawMax test: merge pause modifiers into a single one
nothing to be sorry about
yes, we should that, addressed in this commit 0264355 i have pushed a new commit, you can see it's message what's about, it is self explanatory, lmk if it looks, otherwise it can be merged on my side |
|
LGTM. |
Changelogs
usdcandtokenWithoutDecimal#112.ISablierV2OpenEndedcreateAndDeposit,restartStreamAndDepositandwithdrawMaxnow make calls to internal functions. So, required modifiers have also been added to them.Assertions.solnormalize_functions inBase.t.soldecimals_in theERCMockconstructorPR dependencies
Side note
Modifiers.solare very unorganized. Should we remove categories and just simply make them in alphabetical order?