-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new menu for character control #16
Conversation
With this menu now is possible to take control of the persistent data. Now the player can "delete" the four characters and even restore them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this screen, constantly there was not enough time to do it.
But is not it better to do the same thing as on a PC: give user ability to manually delete .chr
files by putting them on the first start in /sdcard/Android/data/ru.saber_nyan.ddlc/files
?
|
||
|
||
#Added by AlexAzumi | ||
textbutton _("Characters") action [ShowMenu("characters"), SensitiveIf(renpy.get_screen("characters") == None)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not show this button immediately after the first start: it will be a small spoiler. It is better to hide it under some condition.
There's two changes: * To avoid spoilers with this menu, this only can be visible after playthrough zero. * Delete buttons can only be pressed when the character is not flagged as deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, after clicking on "Characters" from the main menu, I got
I'm sorry, but an uncaught exception occurred.
While running game code:
File "game/screens.rpy", line 913, in execute
init -501 screen characters() tag menu:
File "game/screens.rpy", line 913, in execute
init -501 screen characters() tag menu:
File "game/screens.rpy", line 914, in execute
use game_menu(_("Files"), scroll ="viewport"):
File "game/screens.rpy", line 602, in execute
init -501 screen game_menu(title, scroll=None):
File "game/screens.rpy", line 602, in execute
init -501 screen game_menu(title, scroll=None):
File "game/screens.rpy", line 613, in execute
frame:
File "game/screens.rpy", line 616, in execute
has hbox
File "game/screens.rpy", line 622, in execute
frame:
File "game/screens.rpy", line 625, in execute
if scroll == "viewport":
File "game/screens.rpy", line 627, in execute
viewport:
File "game/screens.rpy", line 635, in execute
has vbox
File "game/screens.rpy", line 636, in execute
transclude
File "game/screens.rpy", line 914, in execute
use game_menu(_("Files"), scroll ="viewport"):
File "game/screens.rpy", line 915, in execute
vbox:
File "game/screens.rpy", line 918, in execute
frame:
File "game/screens.rpy", line 923, in execute
vbox:
File "game/screens.rpy", line 929, in execute
python:
File "game/screens.rpy", line 930, in <module>
monika_flag = check_if_exist("monika")
NameError: name 'check_if_exist' is not defined
-- Full Traceback ------------------------------------------------------------
Full traceback:
File "renpy/common/_layout/screen_main_menu.rpym", line 28, in script
python hide:
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\ast.py", line 827, in execute
renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\python.py", line 1764, in py_exec_bytecode
exec bytecode in globals, locals
File "renpy/common/_layout/screen_main_menu.rpym", line 35, in <module>
ui.interact()
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\ui.py", line 287, in interact
rv = renpy.game.interface.interact(roll_forward=roll_forward, **kwargs)
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\display\core.py", line 2565, in interact
scene_lists.replace_transient()
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\display\core.py", line 831, in replace_transient
self.remove(layer, tag)
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\display\core.py", line 1120, in remove
self.hide_or_replace(layer, remove_index, "hide")
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\display\core.py", line 1044, in hide_or_replace
d = oldsle.displayable._hide(now - st, now - at, prefix)
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\display\screen.py", line 445, in _hide
self.update()
File "D:\DEVELOPMENT_IS_MY_LAIFU\RenPy\renpy\display\screen.py", line 580, in update
self.screen.function(**self.scope)
File "game/screens.rpy", line 913, in execute
init -501 screen characters() tag menu:
File "game/screens.rpy", line 913, in execute
init -501 screen characters() tag menu:
File "game/screens.rpy", line 914, in execute
use game_menu(_("Files"), scroll ="viewport"):
File "game/screens.rpy", line 602, in execute
init -501 screen game_menu(title, scroll=None):
File "game/screens.rpy", line 602, in execute
init -501 screen game_menu(title, scroll=None):
File "game/screens.rpy", line 613, in execute
frame:
File "game/screens.rpy", line 616, in execute
has hbox
File "game/screens.rpy", line 622, in execute
frame:
File "game/screens.rpy", line 625, in execute
if scroll == "viewport":
File "game/screens.rpy", line 627, in execute
viewport:
File "game/screens.rpy", line 635, in execute
has vbox
File "game/screens.rpy", line 636, in execute
transclude
File "game/screens.rpy", line 914, in execute
use game_menu(_("Files"), scroll ="viewport"):
File "game/screens.rpy", line 915, in execute
vbox:
File "game/screens.rpy", line 918, in execute
frame:
File "game/screens.rpy", line 923, in execute
vbox:
File "game/screens.rpy", line 929, in execute
python:
File "game/screens.rpy", line 930, in <module>
monika_flag = check_if_exist("monika")
NameError: name 'check_if_exist' is not defined
Windows-8-6.2.9200
Ren'Py 6.99.13.2919
Doki Doki Literature Club! 1.1.0
There's two changes: * To avoid spoilers with this menu, this only can be visible after playthrough zero. * Delete buttons can only be pressed when the character is not flagged as deleted.
…c-android into persistent-control
This reverts commit e68de37.
…c-android into persistent-control
Sorry, I accidentally forgot to push "definitions.rpy" file. |
Aww, I pushed old piece of code... |
This reverts commit a9a315c.
ddlc-android/game/script-ch30.rpy Lines 311 to 319 in ced637e
Now we need to rewrite some of Monica's replicas. Search for the keyword "steam". |
By the way, while deleting I think it would be nice to do something like that. |
That's a good idea, but, if we want to give the best experience, we have to modify the character control, without using persistent data, and creating the |
Changed for @saber-nya function.
🤔 |
Sorry for my bad english! If it's written incorrectly, then write me about it.
So, i merge this PR. |
It could be awesome if I could remove Monika.chr before the first start. You may know there's an easter egg (or not) there. Sorry for incorrect English grammar. |
Hmm, I think we can implement this easter egg with, for example, a few specific gestures in the game's main menu. |
btw where can i put the text file such as poemwords.txt, CAN YOU HEAR ME.txt ? |
With this menu now is possible to take control of the persistent data. The player can "delete" the four characters and even restore them.