Skip to content

Commit

Permalink
[Upgrade Assistant] Update copy to use "issues" instead of "warnings" (
Browse files Browse the repository at this point in the history
  • Loading branch information
alisonelizabeth authored and sabarasaba committed Oct 20, 2021
1 parent c4e32b9 commit 2c5bce9
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const i18nTexts = {
defaultMessage: 'Identify deprecated API use and update your applications',
}),
toggleTitle: i18n.translate('xpack.upgradeAssistant.overview.toggleTitle', {
defaultMessage: 'Log Elasticsearch deprecation warnings',
defaultMessage: 'Log Elasticsearch deprecation issues',
}),
analyzeTitle: i18n.translate('xpack.upgradeAssistant.overview.analyzeTitle', {
defaultMessage: 'Analyze deprecation logs',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ const i18nTexts = {
defaultMessage: 'Upgrade Assistant',
}),
esDeprecations: i18n.translate('xpack.upgradeAssistant.breadcrumb.esDeprecationsLabel', {
defaultMessage: 'Elasticsearch deprecation warnings',
defaultMessage: 'Elasticsearch deprecation issues',
}),
kibanaDeprecations: i18n.translate(
'xpack.upgradeAssistant.breadcrumb.kibanaDeprecationsLabel',
{
defaultMessage: 'Kibana deprecation warnings',
defaultMessage: 'Kibana deprecation issues',
}
),
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('Status API', () => {
expect(resp.payload).toEqual({
readyForUpgrade: false,
details:
'You have 1 Elasticsearch deprecation warnings and 1 Kibana deprecation warnings that must be resolved before upgrading.',
'You have 1 Elasticsearch deprecation issue and 1 Kibana deprecation issue that must be resolved before upgrading.',
});
});

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/upgrade_assistant/server/routes/status.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function registerUpgradeStatusRoute({ router, lib: { handleEsError } }: R

return i18n.translate('xpack.upgradeAssistant.status.deprecationsUnresolvedMessage', {
defaultMessage:
'You have {esTotalCriticalDeps} Elasticsearch deprecation warnings and {kibanaTotalCriticalDeps} Kibana deprecation warnings that must be resolved before upgrading.',
'You have {esTotalCriticalDeps} Elasticsearch deprecation {esTotalCriticalDeps, plural, one {issue} other {issues}} and {kibanaTotalCriticalDeps} Kibana deprecation {kibanaTotalCriticalDeps, plural, one {issue} other {issues}} that must be resolved before upgrading.',
values: { esTotalCriticalDeps, kibanaTotalCriticalDeps },
});
};
Expand Down

0 comments on commit 2c5bce9

Please sign in to comment.