Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: breadcrumb should support an ordered list (SEO) #1569

Closed
digitalcortex opened this issue Feb 1, 2023 · 2 comments
Closed

bug: breadcrumb should support an ordered list (SEO) #1569

digitalcortex opened this issue Feb 1, 2023 · 2 comments

Comments

@digitalcortex
Copy link

digitalcortex commented Feb 1, 2023 •
edited
Loading

What version of daisyUI are you using?

v2.49.0

Describe your issue

I tried using breadcrumbs from example page but the source code is written with <ul>. Changing <ul> to <ol> didn't help probably because DaisyUI does not include style definitions for an ordered list inside the breadcrumb tag.

Using ordered list <ol> for breadcrumbs is semantically better and may be important for SEO. By using ordered list you are telling the search engine that the order of the links inside your breadcrumb is important. Ordered list for breadcrumbs creates a meaningful hierarchy for your internal navigation

Is there any way to update class definition to support <ol> tags as well?

What browsers are you seeing the problem on?

No response

Reproduction URL (optional)

No response
@digitalcortex digitalcortex changed the title bug: tag inside breadcrumb container should be an ordered list bug: tag inside breadcrumb container should be an ordered list (SEO issue) Feb 1, 2023
@digitalcortex digitalcortex changed the title bug: tag inside breadcrumb container should be an ordered list (SEO issue) bug: tag inside breadcrumb container should be an ordered list (SEO) Feb 1, 2023
@digitalcortex digitalcortex changed the title bug: tag inside breadcrumb container should be an ordered list (SEO) bug: breadcrumb should support an ordered list (SEO) Feb 1, 2023
amirsinaa added a commit to amirsinaa/daisyui that referenced this issue Mar 1, 2023
@amirsinaa
fix: saadeghi#1569 extend breadcrumb support for an ordered list
412eeb2
@amirsinaa amirsinaa mentioned this issue Mar 1, 2023
Merged
@amirsinaa
Copy link
Contributor

Hi,
I've fixed this issue: #1648
@saadeghi @digitalcortex

@saadeghi
Copy link
Owner

saadeghi commented Mar 1, 2023

Thank you @amirsinaa. This will be merged today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@saadeghi @amirsinaa @digitalcortex