Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClearButton A11Y and Search Input disabled fixes #314

Merged
merged 5 commits into from
Mar 9, 2024
Merged

ClearButton A11Y and Search Input disabled fixes #314

merged 5 commits into from
Mar 9, 2024

Conversation

joselrio
Copy link
Contributor

@joselrio joselrio commented Mar 7, 2024

This PR will enable clear button for a11y and it will enable search input when allowNewOption=true.
Search input related fix will also fix the issue #313

gnbm
gnbm approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joselrio the aria-label for the clear button could be a config like we have similar others so we could do something like translations or changing the text content

@gnbm gnbm merged commit 27fa4c1 into sa-si-dev:master Mar 9, 2024
@gnbm gnbm mentioned this pull request Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnbm gnbm gnbm approved these changes

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd approved these changes

@OS-giulianasilva OS-giulianasilva OS-giulianasilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joselrio @gnbm @JoaoFerreira-FrontEnd @OS-giulianasilva