Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements with new options #253

Merged
merged 4 commits into from
May 21, 2023
Merged

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented May 12, 2023

This PR is to provide some accessibility improvements with new options that will partially help with the reported issue #246

What was happening?

  1. Axe scan:

image

  1. Wave:

image

What are the new results?

  1. Axe scan:

image

  1. Wave:

image

What was done?

  • Added new 'searchFormLabel' option. This option will the used to enhance accessibility when using the search functionality on the dropdowns. Default = 'Search'

  • Added new 'ariaLabelText' option. This option will the used to enhance accessibility when focusing on the dropdown wrapper making it verbose. Default = 'Options list'

Still Missing

Regarding accessibility, there are still several issues pending that should be covered asap (as mentioned in the issue #246 ).
Such as:

  • screen readers are not being able to read the options while navigating the list of options since the focus seems to stay on the search box (they spell "blank" or the text that is on the search box);
  • screen readers are not being able to read the selected options;
  • once on the list of options we cannot go back to the search box;
  • we cannot reach the clear icons using the keyboard and they're not read by the screen readers;

gnbm added 4 commits May 12, 2023 22:50
Added new 'searchFormLabel' option.
This option will the used to enhance accessibility when using search functionality on the dropdowns.

Added new 'ariaLabelText' option.
This option will the used to enhance accessibility when focusing the dropdown wrapper making it verbose.
@sa-si-dev
Copy link
Owner

@gnbm Thanks for your contribution.

I will check and merge it with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants