Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken display of options with icons #311

Closed
dragomano opened this issue Feb 27, 2024 · 4 comments
Closed

Broken display of options with icons #311

dragomano opened this issue Feb 27, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@dragomano
Copy link

Source code

		<div id="tags" name="tags"></div>
		<script>
			VirtualSelect.init({
				ele: "#tags",
				dropboxWrapper: "body",
				maxWidth: "100%",
				multiple: true,
				search: true,
				markSearchResults: true,
				showValueAsTags: true,
				allowNewOption: false,
				showSelectedOptionsFirst: true,
				placeholder: "Select tags or add new",
				noSearchResultsText: "Sorry, no matches were found",
				searchPlaceholderText: "Search",
				noOptionsText: "No tags yet",
				clearButtonText: "Remove",
				maxValues: 10,
				options: [{"label":"<i class=\"fas fa-snowman\" aria-hidden=\"true\"><\/i> Cat","value":2},{"label":"<i class=\"fas fa-cheese\" aria-hidden=\"true\"><\/i> Tag","value":1}],
				selectedValue: [2,1]
			});
		</script>

v1.0.40
sshot-6

v1.0.41
sshot-4

Did something get broken somewhere?

@gnbm
Copy link
Collaborator

gnbm commented Mar 1, 2024

@dragomano Seems like a regression issue while using multiple: true and when having tags with HTML.

@gnbm gnbm added the bug Something isn't working label Mar 2, 2024
gnbm added a commit to gnbm/virtual-select that referenced this issue Mar 7, 2024
@gnbm
Copy link
Collaborator

gnbm commented Mar 7, 2024

@dragomano Opened a PR that includes a fix for this.
Can you please review it while I wait for @sa-si-dev validation?

@dragomano
Copy link
Author

Confirm, the fix resolved this problem.

gnbm added a commit that referenced this issue Mar 8, 2024
@gnbm
Copy link
Collaborator

gnbm commented Mar 12, 2024

Fixed in v1.0.42

@gnbm gnbm closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants