Remove plugins that are already part of the s9y core repo: gravatar, multilingual, quicksearch, authors #176
Conversation
The plugins were initially both in spartacus and in the s9y core to bundle them, while having the option to provide updates without needing a s9y release. But in many years now that situation never occured, these plugins are stable enough. Thus removing them will reduce maintenance work that was already being neglected: syncing changes in the two repos.
|
Prior discussion in s9y/Serendipity#821. This PR is a proposal, I will not click the merge button without agreement by the others. @garvinhicking, @surrim, @stevleibelt, since you participated in the original issue, what do you think? |
|
@onli sorry to tell, but I am still not technical deep enough involved into this topic to write a usable answer :-(. |
|
@stevleibelt Thanks for responding though :) |
There was a problem hiding this comment.
I think at some point we wanted to reduce the "load" in the core bundle, and this was a test run for that too.
Dual maintenance is the more concrete burden, so I'm ok to drop it.... but do you really think all these should go into the core?
Gravatar+authors+quicksearch probably yes, but multilingual maybe move to spartacus only...?
|
Hm. The multilingual plugin had compatibility issues, to link it to a s9y version was a try to solve them, while also aimed at getting the developer on board. It is probably not used often enough (and not by enough of the old core devs and users) to make it a core plugin, but the functionality fits well. Also, since it's already in the core right now, wouldn't removing it be problematic for old installations? Should we remove it with an upgrader task if not installed? I'm undecided, leaning towards leaving it in the core since it's what the maintainer wanted back then. And we'd have to solve the incompatibility with old s9y versions, maybe just by requiring a newer s9y version. For me it wouldn't be a problem to have it live in spartacus. |
|
Just a quick comment - the main reason I’ve been using s9y for my blog for the past 20 years (and still ongoing) is because of the multilingual plugin. :) |
|
There are simply too many parts of the multilingual plugin already in the core outside the plugin file, it doesn't make sense to have it outside in a separate repository, that might only cause version conflict and compatibility issues. By having it in the core it is ensured that all parts of it working together seamlessly. |
|
Alright. I have no issues moving these plugins "back home", go for it! Thanks! |
The plugins were initially both in spartacus and in the s9y core to bundle them while still having the option to provide updates without needing a s9y release. But in many years now that situation never occurred with a critical update, these plugins are stable enough. Thus removing them will reduce maintenance work that was already being neglected: syncing changes in the two repos.
Also a thought: While initially having gravatar and multilingual plugin in Spartacus was important to provide them to old s9y version, by now they were bundled in s9y a while longer, so that problem in my eyes is solved for these.