local dns cache for statistics plugin #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -857,7 +857,14 @@ function extendedVisitorStatistics($max_items){ | |||
| echo "<td class = \"".$color."\">".wordwrap($row['browser'], 25, "<br />", 1)."</td>\n"; | |||
| echo "<td class = \"".$color."\">"; | |||
| if ($row['ip']){ | |||
| echo wordwrap(gethostbyaddr($row['ip']), 25, "\n", 1); | |||
| $curIP = $row['ip']; | |||
| if (array_key_exists($curIP, $resolvedHosts)) { | |||
There was a problem hiding this comment.
Has $resolvedHosts been declared before? Otherwise this will generate a notice (at least in PHP 5.3+). Apart from that collecting duplicate IPs seems to be a good idea ...
|
Sorry, missed the declaration line. Added it and also expanded my tabs to spaces to match the indentation of the rest of the file. I think it's okay to cache on per request basis. Or do you think we should hold the hosts cached for a bigger scope? |
|
Great! Many thanks for the contribution! (Man, I love github pull requests! This is sooo easy) |
garvinhicking
added a commit
that referenced
this pull request
Mar 3, 2012
local dns cache for statistics plugin
|
github pull requests are full of win :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a local cache for resolved hosts in the statistics plugin to save time.