package deets...json...editor...license #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanve
commented
Aug 16, 2018
| const fs = require("fs") | ||
| let pkg = fs.readFileSync("./package.json", "utf8") | ||
| pkg = JSON.parse(pkg) | ||
| console.log(pkg) |
There was a problem hiding this comment.
JSON.parse will throw error if invalid
ryanve
commented
Aug 16, 2018
| "name": "@s9a/tape", | ||
| "version": "0.0.0", | ||
| "lockfileVersion": 1 | ||
| } |
There was a problem hiding this comment.
npm init as 0.0.0 so that first bump via npm version minor will be isolated bump to 0.1.0 for first release on npm
ryanve
commented
Aug 16, 2018
| @@ -0,0 +1,7 @@ | |||
| ISC License | |||
|
|
|||
| Copyright (c) s9a | |||
There was a problem hiding this comment.
Omitting year because git history exists
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like
CC0-1.0but after some research and comparing to projects npx, H5BP, Solarized, palx, the ISC License seems safer for widest reach. Changeable in a future version. Compare licenses.