Merge pull request Expensify#46704 from software-mansion-labs/fix-beh…

…avior-of-explanation-modal [HybridApp] Adjust props of explanation modal
s77rt · Aug 5, 2024 · a4e5a52 · a4e5a52
2 parents e909496 + 4e0337d
commit a4e5a52
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/components/ExplanationModal.tsx b/src/components/ExplanationModal.tsx
@@ -10,7 +10,7 @@ import FeatureTrainingModal from './FeatureTrainingModal';
 function ExplanationModal() {
     const {translate} = useLocalize();
 
-    const onConfirm = useCallback(() => {
+    const onClose = useCallback(() => {
         Welcome.completeHybridAppOnboarding();
 
         // We need to check if standard NewDot onboarding is completed.
@@ -32,7 +32,7 @@ function ExplanationModal() {
             secondaryDescription={translate('onboarding.explanationModal.secondaryDescription')}
             confirmText={translate('footer.getStarted')}
             videoURL={CONST.WELCOME_VIDEO_URL}
-            onConfirm={onConfirm}
+            onClose={onClose}
         />
     );
 }

diff --git a/src/components/FeatureTrainingModal.tsx b/src/components/FeatureTrainingModal.tsx
@@ -63,6 +63,9 @@ type FeatureTrainingModalProps = {
     /** A callback to call when user confirms the tutorial */
     onConfirm?: () => void;
 
+    /** A callback to call when modal closes */
+    onClose?: () => void;
+
     /** Text to show on secondary button */
     helpText?: string;
 
@@ -80,6 +83,7 @@ function FeatureTrainingModal({
     shouldShowDismissModalOption = false,
     confirmText = '',
     onConfirm = () => {},
+    onClose = () => {},
     helpText = '',
     onHelp = () => {},
 }: FeatureTrainingModalProps) {
@@ -166,7 +170,8 @@ function FeatureTrainingModal({
         }
         setIsModalVisible(false);
         Navigation.goBack();
-    }, [willShowAgain]);
+        onClose?.();
+    }, [onClose, willShowAgain]);
 
     const closeAndConfirmModal = useCallback(() => {
         closeModal();