Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in action.yml #93

Closed
awhitford opened this issue Feb 15, 2021 · 0 comments · Fixed by #94
Closed

Typos in action.yml #93

awhitford opened this issue Feb 15, 2021 · 0 comments · Fixed by #94
Labels
documentation Improvements or additions to documentation.

Comments

@awhitford
Copy link
Contributor

maven-settings-action/action.yml

Line 1 in 40cb7c6

name: 'maven-setings-action'

The name should be maven-settings-action (two t's).

maven-settings-action/action.yml

Line 10 in 40cb7c6

description: 'servers definition in joson array, eg: [{"id": "serverId", "username": "username", "password": "password"}]'

The definition is a json array (not joson).
awhitford added a commit to awhitford/maven-settings-action that referenced this issue Feb 15, 2021
@awhitford
Corrected typos. Resolves s4u#93.
175b85e
@awhitford awhitford mentioned this issue Feb 15, 2021
Merged
@slawekjaranowski slawekjaranowski linked a pull request Feb 16, 2021 that will close this issue
Corrected typos. Resolves #93. #94
Merged
slawekjaranowski added a commit that referenced this issue Feb 16, 2021
@slawekjaranowski
Merge pull request #94 from awhitford/typos
abf1253 
Corrected typos. Resolves #93.
@slawekjaranowski slawekjaranowski added the documentation Improvements or additions to documentation. label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected typos. Resolves #93. awhitford/maven-settings-action
2 participants
@awhitford @slawekjaranowski