Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several major errors in the implementation of output #1315

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ctrlcctrlv
Copy link

Should be backwards compatible. Tests pass.

fred@デブ狸~/Workspace/s3cmd% ./run-tests.py
System encoding: UTF-8
Using bucket prefix: 'fred-'
Using server profile: 'aws'
  1  Remove test buckets ..... OK
  2  Verify no test buckets .. OK
  3  Create one bucket (EU) .. OK
  4  Create multiple buckets . OK
  5  Invalid bucket name ..... OK
  6  Buckets list ............ OK
  7  Create cache dir(rm) .... SKIP
  8  Create cache dir(mk) .... OK
  9  Sync to S3 .............. OK
 10  Create cache dir ........ OK
 11  Sync to S3 with caching . OK
 12  Remove local file ....... OK
 13  Sync to S3 and delete removed with caching  OK
 14  Remove cache dir ........ OK
 15  Create empty dir ........ OK
 16  Sync to S3 empty dir without keep dir  OK
 17  Sync to S3 empty dir with keep dir  OK
 18  Remove cache dir ........ OK
 19  Sync UTF-8 to S3 ........ OK
 20  List bucket content ..... OK
 21  List bucket recursive ... OK
 22  Recursive put ........... OK
 23  Clean testsuite-out/(rm)  SKIP
 24  Clean testsuite-out/(mk)  OK
 25  Put from stdin .......... OK
 26  Put multipart ........... OK
 27  Multipart large put from stdin  OK
 28  Clean testsuite-out/(rm)  OK
 29  Clean testsuite-out/(mk)  OK
 30  Put multiple files ...... OK
 31  Move without '/' ........ OK
 32  Move recursive w/a '/' .. OK
 33  Move multiple files ..... OK
 34  Clean testsuite-out/(rm)  OK
 35  Clean testsuite-out/(mk)  OK
 36  Sync from S3 ............ OK
 37  Create 'emptytests/withoutdirs'  SKIP
 38  Create 'emptytests/withdirs/'  SKIP
 39  Sync from S3 no empty dir  OK
 40  Sync from S3 with empty dir  OK
 41  Remove 'emptytests/' .... OK
 42  Remove 'dir-test/' ...... OK
 43  Create file-dir dir ..... OK
 44  Skip over dir ........... OK
 45  Clean testsuite-out/(rm)  OK
 46  Clean testsuite-out/(mk)  OK
 47  Put public, guess MIME .. OK
 48  Retrieve from URL ....... OK
 49  Change ACL to Private ... OK
 50  Verify Private ACL ...... OK
 51  Change ACL to Public .... OK
 52  Verify Public ACL ....... OK
 53  Sync more to S3 ......... OK
 54  Change file cksum1.txt .. OK
 55  Change file cksum33.txt . OK
 56  Don't check MD5 ......... OK
 57  Check MD5 ............... OK
 58  Rename within S3 ........ OK
 59  Rename (NoSuchKey) ...... OK
 60  Sync more from S3 (invalid src)  OK
 61  Sync more from S3 ....... OK
 62  Remove dst dir for get .. OK
 63  Get multiple files ...... OK
 64  Put unicode filenames ... OK
 65  Make dst dir for get .... OK
 66  Get unicode filenames ... OK
 67  Get multiple files ...... OK
 68  blah.txt / Blah.txt ..... OK
 69  Copy between buckets .... OK
 70  Recursive copy, set ACL . OK
 71  Verify ACL and MIME type  OK
 72  Verify MIME type ........ SKIP
 73  Modify MIME type ........ OK
 74  Verify ACL and MIME type  OK
 75  Verify MIME type ........ SKIP
 76  Modify MIME type back ... OK
 77  Verify ACL and MIME type  OK
 78  Verify MIME type ........ SKIP
 79  Add cache-control header  OK
 80  HEAD check Cache-Control present  OK
 81  Remove cache-control header  OK
 82  HEAD check Cache-Control not present  OK
 83  sign string ............. OK
 84  signurl time ............ OK
 85  signurl time offset ..... OK
 86  signurl content disposition and type  OK
 87  Rename within S3 ........ OK
 88  Sync remote2remote ...... OK
 89  Exclude directory ....... OK
 90  Don't put symbolic links  OK
 91  Put symbolic links ...... OK
 92  Sync symbolic links ..... OK
 93  Multi-source move ....... OK
 94  Verify move ............. OK
 95  List all ................ OK
 96  Simple delete ........... OK
 97  Simple delete with rm ... OK
 98  Create expiration rule with days and prefix  OK
 99  Create expiration rule with date and prefix  OK
100  Create expiration rule with days only  OK
101  Create expiration rule with date only  OK
102  Get current expiration setting  OK
103  Delete expiration rule .. OK
104  Set requester pays ...... OK
105  Get requester pays flag . OK
106  ls using requester pays flag  OK
107  Clear requester pays .... OK
108  Get requester pays flag . OK
109  Recursive delete maximum exceeded  OK
110  Recursive delete ........ OK
111  Recursive delete with rm  OK
112  Recursive delete all .... OK
113  Remove empty bucket ..... OK
114  Remove remaining buckets  OK

@ctrlcctrlv
Copy link
Author

Also this is how I noticed this issue.

https://stackoverflow.com/questions/13273130/download-file-from-s3-to-stdout

--no-progress should not be needed to do this:

Screenshot_20230318_185316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant