Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build-environment triggers and fixes #336

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

m-ildefons
Copy link
Contributor

  • Use docker actions with login to ensure authentication succeeds for the push of the container images to quay.io
  • Allow manually triggering the workflow
  • Build the environments only on changes to the respective source files otherwise

Signed-off-by: Moritz Röhrich moritz.rohrich@suse.com

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

- Use docker actions with login to ensure authentication succeeds for
  the push of the container images to quay.io
- Allow manually triggering the workflow
- Build the environments only on changes to the respective source files
  otherwise

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
@m-ildefons m-ildefons requested a review from jhmarina February 9, 2023 12:20
@jhmarina jhmarina added this to the v0.12.0 milestone Feb 9, 2023
Copy link
Contributor

@jhmarina jhmarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m-ildefons m-ildefons merged commit 2716df2 into s3gw-tech:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants