Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the release captain howto to the latest workflow. #201

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Nov 7, 2022

Signed-off-by: Volker Theile vtheile@suse.com

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

@votdev votdev added the kind/documentation Improvements or additions to documentation label Nov 7, 2022
@votdev votdev added this to the v0.8.0 milestone Nov 7, 2022
@votdev votdev self-assigned this Nov 7, 2022
@votdev votdev force-pushed the adapt_release_captain branch 3 times, most recently from 1115539 to 6bf137c Compare November 7, 2022 16:23
@votdev
Copy link
Contributor Author

votdev commented Nov 8, 2022

I'm not happy with the changelog processing. It's much too complicated right now. Updating the release date right before the release requires now 2 PRs per sub-project:

  1. Do the changes in main.
  2. Backport them to the release branch.

Doing that for s3gw-ui, s3gw-tools and s3gw-charts requires at least 6 PRs. That's too much. Getting them reviewed, accepted and merged will surely slow down the release process dramatically.

@jhmarina
Copy link
Contributor

jhmarina commented Nov 8, 2022

There's this issue for merging the tools & charts repo to simplify the process a bit

@votdev votdev force-pushed the adapt_release_captain branch from 6bf137c to c043541 Compare November 8, 2022 09:49
@votdev
Copy link
Contributor Author

votdev commented Nov 8, 2022

There's this issue for merging the tools & charts repo to simplify the process a bit

That will simplify the release process, but IMO it is to late to include this into 0.8.0. The next release captain will need to update the ADR after #166 has been merged.

@votdev votdev force-pushed the adapt_release_captain branch 2 times, most recently from 2d374c1 to ff81052 Compare November 8, 2022 10:24
Copy link
Contributor

@jhmarina jhmarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giubacc
Copy link

giubacc commented Nov 8, 2022

it seems good; remind me, what was the need for an annotated tag?

@votdev
Copy link
Contributor Author

votdev commented Nov 8, 2022

it seems good; remind me, what was the need for an annotated tag?

Check https://git-scm.com/book/en/v2/Git-Basics-Tagging. The need is that only this type of tag triggers the GH workflow to build the images. @m-ildefons can give more details on that.

giubacc
giubacc previously approved these changes Nov 8, 2022
@m-ildefons
Copy link
Contributor

It needs to be annotated (-a flag) and IMO it needs to be signed (-s flag) too, which afaik can't be done with the web interface. The command line for that is:

git tag -a -s vX.Y.Z

@votdev votdev force-pushed the adapt_release_captain branch 3 times, most recently from 0366d0d to 8004f0b Compare November 8, 2022 13:16
docs/decisions/0004-release-captain.md Outdated Show resolved Hide resolved
@votdev votdev force-pushed the adapt_release_captain branch 3 times, most recently from 8f53e43 to f28c5f2 Compare November 10, 2022 10:45
@votdev votdev force-pushed the adapt_release_captain branch 2 times, most recently from ee7633e to b690906 Compare November 10, 2022 11:43
@votdev votdev force-pushed the adapt_release_captain branch from b690906 to 75c7dd3 Compare November 10, 2022 11:57
Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev force-pushed the adapt_release_captain branch from 75c7dd3 to 0113a19 Compare November 10, 2022 12:03
@votdev votdev merged commit d4f4686 into s3gw-tech:main Nov 10, 2022
@votdev votdev deleted the adapt_release_captain branch November 10, 2022 12:53
m-ildefons pushed a commit to m-ildefons/s3gw that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants