Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add labels to certificate manager resources #80

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

m-ildefons
Copy link
Contributor

Add missing labels to certificate management resources. This allows for clean upgrades and deinstallation when the chart has changed significantly or resources are moved between files between releases.

Signed-off-by: Moritz Röhrich moritz.rohrich@suse.com

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

Add missing labels to certificate management resources. This allows for
clean upgrades and deinstallation when the chart has changed
significantly or resources are moved between files between releases.

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
@m-ildefons m-ildefons requested a review from giubacc December 21, 2022 17:51
Copy link
Contributor

@giubacc giubacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this is safe and you have tested it, so LGTM (but please confirm this before merge)

@m-ildefons
Copy link
Contributor Author

Yes. Labels are metadata that can be associated with any resource. They're used to identify groups of resources that belong together.

@m-ildefons m-ildefons merged commit 6f077b1 into s3gw-tech:main Dec 22, 2022
m-ildefons added a commit to m-ildefons/s3gw that referenced this pull request Dec 22, 2022
Fast-forward charts subrepo to include s3gw-tech/s3gw-charts#80

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants