Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append_session inner loop while condition #91

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: append_session inner loop while condition #91

merged 1 commit into from
Dec 2, 2024

Conversation

sgbalogh
Copy link
Member

@sgbalogh sgbalogh commented Dec 2, 2024

Resolves #90

Reproduces with this:

rand_key=$(head -c 8 /dev/urandom | base64) && echo $rand_key
count=1; while [ "$count" -le 1000 ] ; do echo "$count $rand_key"; ((count++)); done \
        | s2 stream my-basin4 my-stream1 append

which returns:

sbFi2e7W3iw=
Error:
  × Main thread panicked.
  ├─▶ at /Users/sb/.cargo/git/checkouts/s2-sdk-rust-6c37de187e75d8b0/d40de3d/src/append_session.rs:293:5
  ╰─▶ assertion `left == right` failed
        left: 1
       right: 0
  help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.

When version of SDK used by CLI is updated, appends work as expected.

@sgbalogh sgbalogh requested a review from a team as a code owner December 2, 2024 19:54
Copy link
Member

@shikhar shikhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description vs code change ratio :D

@sgbalogh sgbalogh merged commit 53a6bac into main Dec 2, 2024
3 checks passed
@sgbalogh sgbalogh deleted the fix2 branch December 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

append_session assertion failure
2 participants