Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ditch bools around lazy connection in favour of an enum #43

Closed
shikhar opened this issue Nov 5, 2024 · 0 comments · Fixed by #49
Closed

Ditch bools around lazy connection in favour of an enum #43

shikhar opened this issue Nov 5, 2024 · 0 comments · Fixed by #49
Assignees
@vrongmeal

Comments

@shikhar
Copy link
Member

shikhar commented Nov 5, 2024

Boolean parameters can be confusing to read and bug-prone, for the connect lazy optionality create an enum with variants for Eager & Lazy, and use consistently.
vrongmeal added a commit that referenced this issue Nov 8, 2024
@vrongmeal
feat: Add ConnectionMode enum
ca7612d 
Resolves: #43

Signed-off-by: Vaibhav Rabber <vaibhav@s2.dev>
@vrongmeal vrongmeal mentioned this issue Nov 8, 2024
Merged
@shikhar shikhar added the M1 label Nov 8, 2024
vrongmeal added a commit that referenced this issue Nov 14, 2024
@vrongmeal
fix: Only connect lazily (remove option to connect eagerly) (#49)
94e6950 
Resolves: #43

---------

Signed-off-by: Vaibhav Rabber <vaibhav@s2.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrongmeal vrongmeal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Only connect lazily (remove option to connect eagerly) s2-streamstore/s2-sdk-rust
2 participants
@shikhar @vrongmeal