Supply live tracer #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoueh
reviewed
Jan 25, 2024
core/state/metadata.go
Outdated
|
|
||
| // TODO: to be removed, it's useful for logs while developing | ||
| // String returns a string representation of the reason. | ||
| func (r BalanceChangeReason) String() string { |
There was a problem hiding this comment.
Feels like this would be a good addition to the core code directly, it's probably worth it.
ziogaschr
commented
Jan 30, 2024
ziogaschr
commented
Jan 30, 2024
ziogaschr
commented
Jan 30, 2024
s1na
requested changes
Jan 31, 2024
it is being handled in OnGenesisBlock
make use of lumberjack for rotating the trace logs every some MBs
ziogaschr
commented
Feb 2, 2024
When we receive a bad NewPayload, we currently emit a lot of data to the logging facilities. This PR makes it so we print less data.
accounts/abi: remove unused err set and check
This commit fixes several missing interface-checks, where the code did not properly verify a Hook before calling it. It also fixes an error where the tracer was not set in the vmconfig during t8n initialization. It also adds a testcase which verifies the tracing-output during t8n executio. The testcase currently only checks the jsonlogger, but can be extended. This change also removes a spurious 'null' output in the tracing, when tracing result is null.
Since Go 1.22 has deprecated certain elliptic curve operations, this PR removes references to the affected functions and replaces them with a custom implementation in package crypto. This causes backwards-incompatible changes in some places. --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Felix Lange <fjl@twurst.com>
The Prepare-method of consensus engine might modify the time-field in a header, so it should be called prior to checks that rely on it
…#29290) This changes makes it so that when `evm statetest` executes, regardless of whether `--json` is specified or not, the stateroot is printed on `stderr` as a `jsonl` line. This enables speedier execution of testcases in goevmlab, in cases where full execution op-by-op is not required.
This PR modifies the consensus interface to wrap the body fields.
|
Closing in favor of ethereum#29347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.