Skip to content

Commit

Permalink
fix blank output image name (ethereum#515)
Browse files Browse the repository at this point in the history
  • Loading branch information
wanwiset25 authored Apr 2, 2024
1 parent b535866 commit f6ee225
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,13 @@ jobs:
if: github.ref == 'refs/heads/dev-upgrade' && !startsWith(github.ref, 'refs/tags/')
needs: tests
outputs:
output1: ${{ steps.out.outputs.image_name }}
output1: ${{ steps.docker.outputs.image_name }}
steps:
- uses: actions/checkout@v4
- name: Login to Docker Hub
run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login -u ${{ secrets.DOCKER_USERNAME }} --password-stdin
- name: Build and Push Docker images
id: docker
run: |
git_hash=$(git rev-parse --short "$GITHUB_SHA")
image_name=xinfinorg/devnet:dev-upgrade-${git_hash}
Expand All @@ -98,10 +99,8 @@ jobs:
docker push $image_name
docker push xinfinorg/devnet:latest
docker push xinfinorg/devnet:previous
- name: Output image name
id: out
run: echo "image_name=$image_name" >> "$GITHUB_OUTPUT"
echo "image_name=$image_name"
echo "image_name=$image_name" >> "$GITHUB_OUTPUT"
devnet_terraform_apply:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -158,7 +157,7 @@ jobs:
options: |
--inventory inventory.yaml
--extra-vars network=ec2_rpcs
--extra-vars rpc_image=${{ needs.devnet_build_push.outputs.image_name }}
--extra-vars rpc_image=${{ needs.devnet_build_push.outputs.output1 }}
devnet_dev-upgrade_node:
runs-on: ubuntu-latest
Expand Down

0 comments on commit f6ee225

Please sign in to comment.