forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add pull request template (ethereum#299) (ethereum#302)
Co-authored-by: Banana-J <wjrjerome@gmail.com> Co-authored-by: Liam Lai <liam.lai@datameshgroup.com.au>
- Loading branch information
1 parent
368ccdb
commit 89d2cbe
Showing
2 changed files
with
40 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
## Proposed changes | ||
|
||
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue(or XIP) or explain it in the pull request. | ||
You description should at least include below key points: | ||
- Proposed version bump. i.e Major, Minor or patch | ||
- Proposed release date to testnet and mainnet | ||
|
||
## Types of changes | ||
|
||
What types of changes does your code introduce to XDC network? | ||
_Put an `x` in the boxes that apply_ | ||
|
||
- [ ] Bugfix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
- [ ] Documentation Update (if none of the other choices apply) | ||
- [ ] Regular KTLO or any of the maintaince work. e.g code style | ||
|
||
## Impacted Components | ||
|
||
Which part of the codebase this PR will touch base on, | ||
_Put an `x` in the boxes that apply_ | ||
|
||
- [ ] Consensus | ||
- [ ] Geth | ||
- [ ] Network | ||
- [ ] Smart Contract | ||
- [ ] EVM | ||
- [ ] Account | ||
- [ ] Not sure | ||
|
||
## Checklist | ||
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ | ||
|
||
- [ ] This PR have sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage | ||
- [ ] Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet. | ||
- [ ] Tested the backwards compatibility. | ||
- [ ] Tested with XDC nodes running this version co-exist with those running the previous version. | ||
- [ ] Relevant documentation has been updated as part of this PR |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters